Merged
Conversation
DavisVaughan
approved these changes
Jan 28, 2026
9600a40 to
3b478f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#11558
This fixes two issues:
We were passing file URIs to
normalizePath(). On Unix this is fine, it doesn't find the path on disk and so returns the input sincemustWorkis FALSE:But on Windows this produces paths like
C:\Users\lione\Projects\dplyr\file:\C:\Users\lione\OneDrive\Desktop\test.RTo fix this, we detect all URIs rather than just Ark ones.
On Windows, Positron sends encoded file URIs via to the LSP server and via execute-request code locations which look like
c%03instead ofC:. These URIs didn't match the ones we constructed from file paths in the DAP. To fix this, we now normalise the URIs coming from the LSP (did change events for breakpoint invalidation) and from execute requests (so cmd+enter may validate breakpoints).Ideally we'd sanitize all URIs at the DAP/LSP/Jupyter boundaries to a common encoding, but such a large change felt too risky at this point. We will be able to do this when we introduce the notion of a
FileId.Screen.Recording.2026-01-27.at.18.53.47.mov